Add backup option to skip specific projects
What does this MR do and why?
This MR adds support for SKIP_REPOSITORIES_PATHS
environment variable which takes comma separated list of projects or groups and allows to exclude specific projects or groups from repositories backup.
How to set up and validate locally
- Create a backup excluding project or group
bundle exec rake gitlab:backup:create BACKUP=test SKIP_REPOSITORIES_PATHS=giltab-org
- Check that excluded projects/groups were not added to backup
tar -tf tmp/backups/test_gitlab_backup.tar
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Hey @nE0sIghT!
Welcome to our community! We're excited to have you here, and can't wait to review this first MR with you!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @nE0sIghT
added linked-issue label
added 1st contribution label
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
Hi
@axil
! Please review this documentation merge request. This message was generated automatically. You're welcome to improve it.added documentation twtriaged labels
requested review from @axil
@axil
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
mentioned in issue gitlab-org/quality/triage-reports#12578 (closed)
added backend label
added typefeature label
mentioned in issue gitlab-org/quality/triage-reports#12593 (closed)
added groupgeo label
added devopssystems sectioncore platform labels
- Resolved by Yuri Konotopov
- Resolved by Yuri Konotopov
- Resolved by Yuri Konotopov
- Resolved by Yuri Konotopov
- Resolved by Douglas Barbosa Alexandre
Thanks @nE0sIghT! I left some suggestions regarding the documentation.
I'll let @juan-silva assign to an engineer for review
cc @sranasinghe this seems to implement a long-standing issue #18287 (closed)
added Technical Writing docsfeature labels
removed review request for @axil
- Resolved by Douglas Barbosa Alexandre
Hi @axil
We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.
@nE0sIghT you may also request a review by commenting
@gitlab-bot ready
. You can also assign reviewers directly using@gitlab-bot ready @user1 @user2
if you know the relevant reviewer(s), such as those who were involved in a related issue.This message was generated automatically. You're welcome to improve it.
added workflowin dev label and removed workflowready for review label
requested review from @jtapiab
- Resolved by Yuri Konotopov
- Resolved by Yuri Konotopov
- Resolved by Yuri Konotopov
- Resolved by Yuri Konotopov
- Resolved by Douglas Barbosa Alexandre
Thank you @nE0sIghT for this contribution
. I left a few suggestions and comments, please take a look when you have time, they are non-blocking but I highly encourage you to check them if possible.For the backend maintainer who is going to review this. The behavior of this contribution works as expected. The results in my local as follow:
Test case
- Group:
toolbox
- Project:
gitlab-smoke-tests
Project.find_by_full_path("toolbox/gitlab-smoke-tests").disk_path # => "@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b"
Without skipping projects
Then:
bundle exec rake gitlab:backup:create BACKUP=test
tar -tf tmp/backups/test_gitlab_backup.tar | grep "@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b"
Results:
repositories/@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/ repositories/@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/test/ repositories/@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/LATEST repositories/@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/test/001.bundle repositories/@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/test/LATEST repositories/@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/test/001.refs
The project with
disk_path
"@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b" is included in the backup.Skipping projects
bundle exec rake gitlab:backup:create BACKUP=test SKIP_REPOSITORIES_PATHS=toolbox/gitlab-smoke-tests
tar -tf tmp/backups/test_gitlab_backup.tar | grep "@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b"
No results are given for this project.
Tests missing
- Try a project with snippets, snippets should be excluded too.
Edited by Javiera Tapia- Group:
- Resolved by Douglas Barbosa Alexandre
@jtapiab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @ibaum
- Resolved by Douglas Barbosa Alexandre
added workflowin review label and removed workflowin dev label
removed review request for @jtapiab
requested review from @dbalexandre and removed review request for @ibaum
removed review request for @dbalexandre
Hi @dbalexandre
We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.
@nE0sIghT you may also request a review by commenting
@gitlab-bot ready
. You can also assign reviewers directly using@gitlab-bot ready @user1 @user2
if you know the relevant reviewer(s), such as those who were involved in a related issue.This message was generated automatically. You're welcome to improve it.
added workflowin dev label and removed workflowin review label
@gitlab-bot ready @dbalexandre
added workflowready for review label and removed workflowin dev label
requested review from @dbalexandre
@dbalexandre
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
enabled an automatic merge when the pipeline for 52f02e9f succeeds
Thanks, @nE0sIghT! This LGTM, MWPS set
3 Warnings df438207: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. Please add a merge request subtype to this merge request. 2 Messages CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/raketasks/backup_gitlab.md
(Link to current live version) -
doc/raketasks/restore_gitlab.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eugie Limpin (
@eugielimpin
) (UTC+8)Thong Kuah (
@tkuah
) (UTC+12)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for df438207expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
@nE0sIghT, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit 82227b9b
changed milestone to %16.1
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue gitlab-com/www-gitlab-com#34148 (closed)
mentioned in issue #18287 (closed)
mentioned in issue gitlab-com/www-gitlab-com#34233 (closed)
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request !140634 (merged)