Increase Geo secondary SSH Git push limit to 1.86GB
What does this MR do and why?
Enables the feature flag geo_proxy_direct_to_primary by default, to:
- increase the possible size of Git push over SSH against secondary Geo sites from 1GB to 1.86GB.
- speed up Git pushes over SSH against secondary Geo sites.
It eliminates a proxying step through Rails. Which avoids an unnecessary source of problems and inefficiencies. See a before and after flow diagram in this MR.
I'm enabling by default and not removing the FF since it's a significant underlying change. If a significant bug is found, then we, and customers, would want to be able to flip back to the old behavior immediately. Let's keep the FF around at least one release.
There is an issue for investigating further increasing the size limit.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Set up Geo
- Push over SSH against the secondary site
See how this was validated against geo.staging-ref.gitlab.com (Geo is not configured in production gitlab.com).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.