Check if project is not null before processing
What does this MR do and why?
Check if the project is not null before processing.
In cases where the project is returned null by GraphQL, the start function throws an error. This MR fixes that.
Screenshots or screen recordings
No screenshot available.
How to set up and validate locally
TBA
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #412877 (closed)
Merge request reports
Activity
assigned to @svedova
@thomasrandolph I believe the recent changes introduced this tiny bug. I saw this on Sentry and I believe this change fixes that. Since you're the code author, would you mind giving this an initial review?
Also, it'd be awesome if you could help me provide the steps to reproduce this in the MR description
requested review from @thomasrandolph
1 Message 
CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelogtrailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: truetrailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ross Byrne (
@robyrne) (UTC+1, 1 hour behind@svedova)Tristan Read (
@tristan.read) (UTC+12, 10 hours ahead of@svedova)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
mentioned in issue #412877 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 875a4a45 and 307eccdc
Entrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 2.97 MB 2.97 MB - 0.0 %
Note: We do not have exact data for 875a4a45. So we have used data from: a0af3588.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Allure report
allure-report-publishergenerated test report!e2e-test-on-gdk:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+e2e-review-qa:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Govern | 21 | 0 | 0 | 1 | 21 | ❗ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 39 | 0 | 3 | 2 | 42 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+Thanks for pinging me @svedova. Could you check out my questions above?
Bottom line: How is this possible? Is there a more concerning defect that we should be addressing here?
- Resolved by Jose Ivan Vargas
@iamphill Could you take a look at this just for another set of eyes?
I made an assumption that if a Merge Request page loads, it's part of a project. Is that sometimes not true!? (
- Last reply by Thomas Randolph
requested review from @iamphill
mentioned in issue #412874 (closed)
removed review request for @iamphill
requested review from @jivanvl and removed review request for @thomasrandolph
@thomasrandolph, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
changed milestone to %16.1
enabled an automatic merge when the pipeline for 831124ef succeeds
mentioned in commit 8c5d1a0d
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue #413627 (closed)
added releasedcandidate label
