Skip to content

Fixes merge request activity discussions with filters

Phil Hughes requested to merge ph/fixMrActivityFiltersResponse into master

What does this MR do and why?

Fixes a bug where merge requests discussions would get fetched with the users persisted filter when the activity filter feature flag is enabled. With the flag enabled the user could not get certain comments back, with this change we always fetch all discussions and don't persist the value.

Fixes merge request activity discussions with filters

This fixes a bug where the discussions fetched would return based on the users saved filter option. When the activity filter flag is enabled we always fetch all notes and don't persist them.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports