Fix issue with endless redirect
What does this MR do and why?
In an effort to have a solid test suite around the existing registration flow, we'd like to backfill the test suite.
-
Invite registration flow without tasks -
Invite registration flow with tasks
And fix issue with endless redirect and add feature tests for invitation with tasks
How to set up and validate locally
- Setup gdk to simulate SaaS - https://docs.gitlab.com/ee/development/ee_features.html#simulate-a-saas-instance and restart GDK
- Visit any group members page with such url:
groups/<group-path>/-/group_members?open_modal=invite_members_for_task
- Invite new member. Copy invitation link from logs.
- Finish onboarding and make sure you can go to the root path.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #363540 (closed)
Merge request reports
Activity
changed milestone to %Next 1-3 releases
assigned to @syarynovskyi
- A deleted user
added backend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Rutger Wessels (
@rutgerwessels
) (UTC+2, 1 hour behind@syarynovskyi
)Andy Soiron (
@Andysoiron
) (UTC+2, 1 hour behind@syarynovskyi
)test for spec/features/*
Rutger Wessels (
@rutgerwessels
) (UTC+2, 1 hour behind@syarynovskyi
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded featureenhancement label
added workflowin review label and removed workflowin dev label
- Resolved by Doug Stull
@rliu-int Could you pls take a look and then pass it to
@dstull
?
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 02ac9138expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added 487 commits
-
b13a0abf...4971c6ec - 486 commits from branch
master
- 78db168d - Fix issue with endless redirect
-
b13a0abf...4971c6ec - 486 commits from branch
- Resolved by Doug Stull
@rliu-int
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @dstull and removed review request for @rliu-int
- Resolved by Doug Stull
- Resolved by Doug Stull
removed review request for @dstull
added 1 commit
- f45e7142 - Refactor welcome controller, add test coverage
requested review from @dstull
- Resolved by Doug Stull
mentioned in issue #413025 (closed)
- Resolved by Doug Stull
- Resolved by Doug Stull
removed review request for @dstull
added 1 commit
- 02ac9138 - Rename complete_to_signup_onboarding to complete_signup_onboarding
requested review from @dstull
enabled an automatic merge when the pipeline for 13bc63dd succeeds
mentioned in commit 3779a3ab
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label