Skip to content
Snippets Groups Projects

Fix issue with endless redirect

All threads resolved!

What does this MR do and why?

In an effort to have a solid test suite around the existing registration flow, we'd like to backfill the test suite.

  • Invite registration flow without tasks
  • Invite registration flow with tasks

And fix issue with endless redirect and add feature tests for invitation with tasks

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #363540 (closed)

Merge request reports

Merged results pipeline #879183723 passed

Pipeline: GitLab

#879197186

    Pipeline: E2E GDK

    #879206482

      Merged results pipeline passed for 13bc63dd

      Test coverage 82.66% (15.58%) from 2 jobs

      Merged by Doug StullDoug Stull 1 year ago (May 25, 2023 8:07pm UTC)

      Loading

      Pipeline #879436732 failed

      Pipeline failed for 3779a3ab on master

      Test coverage 67.30% (15.58%) from 2 jobs
      10 environments impacted.

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Roy Liu approved this merge request

      approved this merge request

    • :wave: @rliu-int, thanks for approving this merge request.

      This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

      For more info, please refer to the following links:

    • Roy Liu requested review from @dstull and removed review request for @rliu-int

      requested review from @dstull and removed review request for @rliu-int

    • added 1 commit

      • 1c9faeff - Remove unused finish onboarding method

      Compare with previous version

    • Doug Stull
    • Doug Stull
    • Doug Stull removed review request for @dstull

      removed review request for @dstull

    • added 1 commit

      • f45e7142 - Refactor welcome controller, add test coverage

      Compare with previous version

    • Doug Stull
    • mentioned in issue #413025 (closed)

    • Doug Stull
    • Doug Stull
    • Doug Stull removed review request for @dstull

      removed review request for @dstull

    • added 1 commit

      • 02ac9138 - Rename complete_to_signup_onboarding to complete_signup_onboarding

      Compare with previous version

    • Doug Stull resolved all threads

      resolved all threads

    • Doug Stull approved this merge request

      approved this merge request

    • Doug Stull enabled an automatic merge when the pipeline for 13bc63dd succeeds

      enabled an automatic merge when the pipeline for 13bc63dd succeeds

    • merged

    • Doug Stull mentioned in commit 3779a3ab

      mentioned in commit 3779a3ab

    • added workflowstaging label and removed workflowcanary label

    • Please register or sign in to reply
      Loading