Skip to content

Draft: Remove Rails.env.test? checks in GitLab for Slack app code

Luke Duncalfe requested to merge 355896-models-extras-remove-test-env-checks into master

What does this MR do and why?

This MR refactors the series of existing methods in the Integration model that return integration names to have a split between:

  1. Methods that return a filtered list of integrations that are available on the instance.
  2. Methods that return an unfiltered list of all integrations.

We can use 2. when we want to refer to stable lists of integrations that should be the same regardless of GitLab instances or different environments, for example:

  • When building the GraphQL ServiceType enum values (!122985 (merged)).
  • In tests.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #355896 (closed)

Edited by Luke Duncalfe

Merge request reports