Skip to content

Update drawers to use .content-wrapper for height offset

Scott de Jonge requested to merge 407291-update-gldrawer-usage-of-nav-sidebar into master

What does this MR do and why?

Update drawers to use .content-wrapper for height offset

  • Update GlDrawer usage to replace .nav-sidebar, removed with the new navigation, with .content-wrapper to be consistent with other usage
  • Add DRAWER_Z_INDEX to ensure drawer is above top-bar
  • Remove containerClass and constants in dast_profiles_drawer.vue

Screenshots or screen recordings

New navigation

Before After
pre-scan-before-new pre-scan-after-new
scan-profile-before-new scan-profile-after-new

Old navigation

Before After
pre-scan-before-old pre-scan-after-old
scan-profile-before-old scan-profile-after-old

How to set up and validate locally

  1. Toggle the performance bar with p + b
  2. Add system header in /admin/application_settings/appearance
  3. View Pre-scan verification drawer at /-/on_demand_scans/new
    1. Or go to Secure -> On demand scans -> New scan -> Verify configuration
  4. View /-/security/policies/new?type=scan_execution_policy
    1. Or go to Security & Complience -> Policies -> New policy -> Scan Execution Policy

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #407291 (closed)

Merge request reports