Load whats new tab when no items present
What does this MR do and why?
After updating our GitLab to 15.8 (and same when upgrading to 15.9) the help icon showed the dot in the top-right corner stating there is something in the "What's new".
When opening the user menu it shows a 0
value behind "What's New". Clicking on it leads to loading indefinitely.
Fixing this bug
Screenshots or screen recordings
before | after |
---|---|
![]() |
![]() |
How to set up and validate locally
- Login as admin. Go to
/admin/application_settings/preferences
. - In
What’s new
section selectCurrent tier only
. - Open browser console and remove
display-whats-new-notification
key from local storage if present.
bin/rails c
ReleaseHighlight.current_package
- Open last file under
/data/whats_new/*.yml
- Change
available_in: [...]
for all the records to tier different than returned from console. - For example if rails console returned
Free
, change toavailable_in: [Ultimate]
. - If rails console returned
Ultimate
, change toavailable_in: [Premium]
etc.
gdk redis-cli
FLUSHALL
- Restart rails. Login as any user. Open question mark icon in the header.
- Open
What's new
tab. Make sure it shows records from/data/whats_new/*.yml
older file.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #393282 (closed)
Edited by Serhii Yarynovskyi