Skip to content

Extract Ci::CancelPipelineService class

Fabio Pitino requested to merge refactor-pipeline-cancel-running into master

What does this MR do and why?

The Pipeline#cancel_running method had a complex logic and private methods it depended on. This logic required to be extracted into a service object.

With this extraction we also improve the response object for better testing.

Extract Ci::CancelPipelineService class

Move all logic related to canceling a pipeline to a dedicated service object.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Fabio Pitino

Merge request reports