Skip to content

Hide product analytics sensitive settings

Elwyn Benson requested to merge elwyn-gitlab/gitlab-private-fork:408755-sensitive-settings into master

What does this MR do and why?

Replace sensitive Product Analytics form fields within the Project + Admin settings from a regular text input to the InputCopyToggleVisibility component. This means these fields will display as ******* instead of showing the value (which can be toggled).

  • Product analytics configurator connection string
  • Clickhouse connection string
  • Cube API key

This change is related to product analytics, which is an experimental feature behind default off feature flags.

Screenshots or screen recordings

Admin settings

admin-settings-hide-values.gif2

Before After
image image
Project settings

project-settings-hide-values2

Before After
image image

How to set up and validate locally

Note: This feature has a lot of setup steps. If you need help please ask me or I can step through these during a call with you.

  1. Follow these instructions to setup Product Analytics in GDK.

Admin

  • View the admin settings -> general -> product analytics section
  • Verify that expected fields do not display sensitive values by default. Can be toggled, copied, edited.

Project

  • View a project -> settings -> general -> product analytics section
  • Verify that expected fields do not display sensitive values by default. Can be toggled, copied, edited.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #408755

Edited by Elwyn Benson

Merge request reports