GitLab Chat: Add ability to change height of input
What does this MR do and why?
Adds the ability to resize the AI input field to being able to put larger questions in (e.g. code blocks).
- Auto increases the height until 240px
- Adds scrolling beyond 240px
- Shift + Enter will add a new line
- Enter will submit
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Help > Ask GitLab Chat
- Enter a long question
- Verify input field
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.1
added UX UX Paper Cuts ai-assist frontend groupux paper cuts maintenanceusability severity4 typemaintenance + 1 deleted label
assigned to @seggenberger
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
- Resolved by Denys Mishunov
@annabeldunstone please review UX
cc @katiemacoy
assigned to @annabeldunstone
requested review from @annabeldunstone
unassigned @annabeldunstone
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ankit Panchal (
@ankit.panchal
) (UTC+5.5, 3.5 hours ahead of@seggenberger
)Anna Vovchenko (
@anna_vovchenko
) (UTC+3, 1 hour ahead of@seggenberger
)UX Nick Brandt (
@nickbrandt
) (UTC-6, 8 hours behind@seggenberger
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #411677 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f3502c13 and e446468e
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.08 MB 4.1 MB +18.96 KB 0.5 % mainChunk 2.95 MB 2.97 MB +16.24 KB 0.5 % Significant Growth: 42Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.trials.new 187.68 KB 329.71 KB +142.04 KB 75.7 % pages.abuse_reports 37.52 KB 41.03 KB +3.51 KB 9.3 % pages.admin.applications 76.44 KB 79.95 KB +3.51 KB 4.6 % pages.admin.background_migrations 151.15 KB 154.66 KB +3.51 KB 2.3 % pages.admin.geo.designs 169.24 KB 172.75 KB +3.51 KB 2.1 % pages.admin.geo.replicables 169.24 KB 172.75 KB +3.51 KB 2.1 % pages.admin.geo.settings 150.67 KB 154.18 KB +3.51 KB 2.3 % pages.admin.groups.edit 175.36 KB 178.87 KB +3.51 KB 2.0 % pages.admin.groups.new 128.28 KB 131.78 KB +3.51 KB 2.7 % pages.admin.projects 157.33 KB 160.83 KB +3.51 KB 2.2 % The table above is limited to 10 entries. Please look at the full report for more details
New entry points: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.trials.create 0 Bytes 329.63 KB +329.63 KB 100.0 % Significant Reduction: 24Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.feature_flags_user_lists.show 171.17 KB 152.18 KB -18.99 KB -11.1 % pages.admin.application_settings 679.04 KB 663.56 KB -15.49 KB -2.3 % pages.admin.application_settings.advanced_search 694.53 KB 679.05 KB -15.49 KB -2.2 % pages.admin.application_settings.ci_cd 728.15 KB 712.67 KB -15.49 KB -2.1 % pages.admin.application_settings.integrations 691.28 KB 675.79 KB -15.49 KB -2.2 % pages.admin.application_settings.metrics_and_profiling 682.92 KB 667.43 KB -15.49 KB -2.3 % pages.admin.application_settings.network 680.2 KB 664.72 KB -15.49 KB -2.3 % pages.admin.application_settings.reporting 772.4 KB 756.91 KB -15.49 KB -2.0 % pages.admin.application_settings.repository 692.92 KB 677.43 KB -15.49 KB -2.2 % pages.admin.application_settings.service_usage_data 682.88 KB 667.4 KB -15.49 KB -2.3 % The table above is limited to 10 entries. Please look at the full report for more details
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for f3502c13. So we have used data from: 3c319d78.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for e446468eexpand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for e446468eexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
removed review request for @annabeldunstone
added 655 commits
-
14bd2455...96b044fb - 654 commits from branch
master
- c7a4f6e6 - GitLab Chat: Add ability to increase height of text field
-
14bd2455...96b044fb - 654 commits from branch
added 1 commit
- a8b9bccb - GitLab Chat: Add ability to increase height of text field
added 1 commit
- fd0dca52 - GitLab Chat: Add ability to increase height of text field
requested review from @annabeldunstone
requested review from @dmishunov
@dmishunov another small improvement this time for the AI Chat input
- Resolved by Sascha Eggenberger
- Resolved by Denys Mishunov
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Denys Mishunov
I've done the frontend review, @seggenberger. Great change, however some things have to be addressed before the MR is in the mergeable state. Back to you for now
added 1 commit
- c49fe7af - GitLab Chat: Add ability to increase height of text field
added 1 commit
- e9b1f1fe - GitLab Chat: Add ability to increase height of text field
added 1 commit
- d611ba9f - GitLab Chat: Add ability to increase height of text field
@dmishunov
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added 1 commit
- d4691b18 - GitLab Chat: Add ability to increase height of text field
- Resolved by Sascha Eggenberger
@seggenberger I love this!
I just have one note- I think the full-height send button looks odd. Can we separate them as suggested in !121238 (comment 1398113602)?
If we separated the input from the button, we could keep the button dimensions the same at all times, and anchor it to the bottom:
added 1 commit
- d0c05c58 - GitLab Chat: Add ability to increase height of text field
added 1 commit
- e446468e - GitLab Chat: Add ability to increase height of text field
- Resolved by Sascha Eggenberger
@seggenberger I just noticed one small
with this change- something's overflowing because I'm able to horizontally scroll in the drawer:
removed review request for @annabeldunstone
@dmishunov can you set MWPS?
enabled an automatic merge when the pipeline for 4de05a28 succeeds
mentioned in commit 04848534
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)