Support for marking Gitsign certs as Unverified
What does this MR do and why?
A number of users are wishing to sign their commits with x509 certificates that do not meet the current GitLab requirements, namely the presence of a crlDistributionPoints
or non-empty subject
. Commits signed as such do not even show in the GitLab UI as unverified, simply having no signing status next to them. This MR relaxes the restrictions so that those certs are accepted, and instead attempts to move those checks to the verified field.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Create a project within GitLab
- Create a commit and sign it with Gitsign
- View the commit in the project in GitLab
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #295297 (closed)
Edited by ChevronTango