Skip to content

Add option to expand file ref in ExpandVariables

Albert requested to merge alberts-optional-expand-file-in-expand-variables into master

Part 1 of #390252 (closed)

What does this MR do and why?

Add option to expand file ref in ExpandVariables.

This prepares ExpandVariables module for the changes needed to stop expanding file variables into downstream pipelines. Issue #390252 (closed). There is no behaviour change in this MR yet, as the default for expand_file_refs is still true.

The changes in these MR:

  1. Create a factory method in Collection in order to instantiate a Collection from the input of ExpandVariables
  2. Replace the transform method in ExpandVariables with the factory for the collection
  3. Add option to ExpandVariables method to expand file refs. This expands the file ref when it's true, or return the original string otherwise.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Albert

Merge request reports