Enable "terms-as-tokens" prop on filter bar in Plan Analytics pages
What does this MR do and why?
Enables terms-as-tokens
prop on the FilteredSearchBarRoot
(wrapper component for GlFilteredSearch
) in both the Value Stream and Code Review Analytics pages as part of &10305
Screenshots or screen recordings
Page | Before | After |
---|---|---|
Value Stream Analytics | ![]() |
![]() |
Code Review Analytics | ![]() |
![]() |
How to set up and validate locally
- Please make sure that you're on an Ultimate plan.
- Visit VSA for any group or seed data if necessary.
- Visit Code Review Analytics for any project.
- Verify that search bar on both pages displays
terms-as-tokens
behavior and works correctly
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #408682 (closed) and #408692 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @rcrespo3
added 1 commit
- 48c96236 - Enables "terms-as-tokens" prop on filter bar in VSA
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added workflowin dev label and removed workflowready for development label
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Sharmad Nachnolkar (
@snachnolkar
) (UTC+5.5, 9.5 hours ahead of@rcrespo3
)Peter Hegman (
@peterhegman
) (UTC-7, 3 hours behind@rcrespo3
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancerefactor label
added featureenhancement typefeature labels and removed typemaintenance label
removed maintenancerefactor label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8115dcd7 and 7b21fd97
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.02 MB 4.02 MB - 0.0 % mainChunk 2.88 MB 2.88 MB - 0.0 %
Note: We do not have exact data for 8115dcd7. So we have used data from: bf4bc9ca.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 7b21fd97expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Govern | 20 | 0 | 1 | 0 | 21 | ✅ | | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 8 | 0 | 158 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 212 commits
-
48c96236...c161a990 - 211 commits from branch
master
- 7b21fd97 - Enables "terms-as-tokens" prop on filter bar in Plan Analytics pages
-
48c96236...c161a990 - 211 commits from branch
- Resolved by Anna Vovchenko
Hey @snachnolkar, hope all is well! When you get the chance, could you please do the initial frontend review? Thanks!
requested review from @snachnolkar
added workflowin review label and removed workflowin dev label
@snachnolkar
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @anna_vovchenko and removed review request for @snachnolkar
enabled an automatic merge when the pipeline for ceee63c0 succeeds
mentioned in commit 1fdc9dbb
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #408692 (closed)
mentioned in issue #408682 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)