Update "if-jh" rules

Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.

When you're ready for a first review, post @gitlab-bot ready. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with @gitlab-bot ready @user1 @user2.

At any time, if you need help, feel free to post @gitlab-bot help or initiate a mentor session on Discord. Read more on how to get help.

You can comment @gitlab-bot label <label1> <label2> to add labels to your MR. Please see the list of allowed labels in the label command documentation.

This message was generated automatically. You're welcome to improve it.

added Community contribution workflowin dev labels

assigned to @luzhiyuan.deer

	3 Warnings
	This merge request does not refer to an existing milestone.
	Please add a merge request subtype to this merge request.
	Please add a merge request type to this merge request.

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Pipeline Changes

This merge request contains changes to the pipeline configuration for the GitLab project.

Please consider the effect of the changes in this merge request on the following:

Effects on different pipeline types
Effects on non-canonical projects:
- gitlab-foss
- security
- dev
- personal forks
Effects on pipeline performance

Please consider communicating these changes to the broader team following the communication guideline for pipeline changes

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
maintenanceworkflow / maintenancepipelines for CI, Danger	Sam Kim (`@samsam_kim`) (UTC-7)	Kamil Trzciński (`@ayufan`) (UTC+2)
Engineering Productivity	Reviewer review is optional for Engineering Productivity	Jennifer Li (`@jennli`) (UTC-7)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

marked this merge request as ready

changed the description

added 1 commit

6f31266b - Update "if-jh" rules

Compare with previous version

@gitlab-bot ready @godfat-gitlab

added workflowready for review label and removed workflowin dev label

requested review from @godfat-gitlab

@godfat-gitlab, this Community contribution is ready for review.

Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
Add the workflowin dev label if the merge request needs action from the author.

This message was generated automatically. You're welcome to improve it.

mentioned in merge request !118720 (merged)

@luzhiyuan.deer Thanks, I think this makes sense, as long as there's no other projects we need to match.

This is a bit surprising to me though. GitLab Inc has internal GitLab instance which uses some different paths and that's why we match with regular expression.

I have a suggestion to fix the match and I would prefer to see a working pipeline on https://jihulab.com/gitlab-cn/gitlab to see it working. I also added pipeline:run-as-if-jh so we see how this goes in the validation pipeline.

added pipeline:run-as-if-jh label

removed review request for @godfat-gitlab

Hi @godfat-gitlab

We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.

@luzhiyuan.deer you may also request a review by commenting @gitlab-bot ready. You can also assign reviewers directly using @gitlab-bot ready @user1 @user2 if you know the relevant reviewer(s), such as those who were involved in a related issue.

This message was generated automatically. You're welcome to improve it.

added workflowin dev label and removed workflowready for review label

marked this merge request as draft

added 1 commit

449d4049 - Remove '/' prefix

Compare with previous version

Just so you know. I am logging off, and will be unavailable tomorrow. So I'll revisit this on Monday.

mentioned in issue gitlab-org/quality/triage-reports#12439 (closed)

changed the description

mentioned in issue gitlab-org/quality/triage-reports#12483 (closed)

mentioned in issue gitlab-org/quality/triage-reports#12528 (closed)

added Engineering Productivity maintenancepipelines releasedpublished typemaintenance workflowproduction labels and removed workflowin dev label

mentioned in issue gitlab-jh/status-reports#228

added workflowin dev label and removed workflowproduction label

mentioned in issue gitlab-jh/status-reports#230

changed the description

marked this merge request as ready

@gitlab-bot ready @godfat-gitlab

added workflowready for review label and removed workflowin dev label

requested review from @godfat-gitlab

@godfat-gitlab, this Community contribution is ready for review.

Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
Add the workflowin dev label if the merge request needs action from the author.

This message was generated automatically. You're welcome to improve it.

approved this merge request

@godfat-gitlab, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.

For more info, please refer to the following links:

added pipeline:mr-approved label

@godfat-gitlab, thanks for approving this merge request.

This is the first time the merge request has been approved. Please wait for AppSec approval before merging.

cc @gitlab-com/gl-security/appsec this is a JiHu contribution, please follow the JiHu contribution review process.

@jrushford Is it correct that releasedpublished is mistakenly added? This merge request is not merged yet. I am removing it.

@luzhiyuan.deer Thank you, looks good to me. Let's wait for AppSec review.

yeah, sorry, not sure how that happened, thank you

removed releasedpublished label

changed milestone to %16.1

Pipeline Changes

This merge request contains changes to the pipeline configuration for the GitLab project.

Please consider the effect of the changes in this merge request on the following:

Effects on different pipeline types
Effects on non-canonical projects:
- gitlab-foss
- security
- dev
- personal forks
Effects on pipeline performance

Please consider communicating these changes to the broader team following the communication guideline for pipeline changes

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
maintenanceworkflow / maintenancepipelines for CI, Danger	Thomas Hutterer (`@thutterer`) (UTC+2)	David Dieulivol (`@ddieulivol`) (UTC+2)
Engineering Productivity	Reviewer review is optional for Engineering Productivity	Jennifer Li (`@jennli`) (UTC-7)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

approved this merge request

added sec-planningcomplete label

resolved all threads

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@06193063

enabled an automatic merge when the pipeline for 06193063 succeeds

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 449d4049

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
| Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
| Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
| Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@2613f107

merged

@luzhiyuan.deer, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

React with a or a on this comment to describe your experience.
Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

Thanks for your help!

This message was generated automatically. You're welcome to improve it.