Log when deprecated Jira DVCS endpoints are hit
What does this MR do and why?
This MR introduces logging when the deprecated Jira DVCS endpoints are hit.
This will allow us to gather data about who is using the endpoints.
QA
To make it easier, comment out the authentication of the Jira user agent:
diff --git a/lib/api/v3/github.rb b/lib/api/v3/github.rb
index 7348ed612fce..11359528e743 100644
--- a/lib/api/v3/github.rb
+++ b/lib/api/v3/github.rb
@@ -29,7 +29,7 @@ class Github < ::API::Base
feature_category :integrations
before do
- authorize_jira_user_agent!(request)
+ # authorize_jira_user_agent!(request)
authenticate!
reversible_end_of_life!
end
Tail the integrations_json.log
file:
tail -f log/integrations_json.log
Make the following curl
request (replace <YOUR TOKEN>
with a PAT for your local user):
curl --location 'http://gdk.test:3000/api/v3/user/repos?private_token=<YOUR TOKEN>'
You should not see a new log appear.
Enable the flag:
Feature.enable(:jira_dvcs_end_of_life_amnesty)
Make the curl
request again.
You should see a log appear (note, sometimes due to caching of flag the flag might not enable immediately, just try again in a few seconds).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #362168 (closed)
Merge request reports
Activity
changed milestone to %16.0
added Category:Integrations Deliverable GitLab Free GitLab Premium GitLab Ultimate IntegrationJira Technical Writing auto updated breaking change deprecation devopsmanage docsimprovement documentation groupimport and integrate maintenanceremoval milestonep1 sectiondev typemaintenance workflowverification labels
assigned to @.luke
added maintenancerefactor label and removed maintenanceremoval workflowverification labels
added maintenanceusability label and removed maintenancerefactor label
- A deleted user
added backend label
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Rutger Wessels (
@rutgerwessels
) (UTC+2, 10 hours behind@.luke
)Vitali Tatarintev (
@ck3g
) (UTC+2, 10 hours behind@.luke
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Tetiana Chupryna
Hi @carlad-gl! Could you please give this MR its first backend review? Thank you!
changed milestone to %16.1
requested review from @carlad-gl
added 1 commit
- 11a64271 - Move flag check after auth so we log real requests
mentioned in issue #408148 (closed)
- Resolved by Tetiana Chupryna
- Resolved by Tetiana Chupryna
requested review from @brytannia and removed review request for @carlad-gl
@carlad-gl
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 42f4f713 succeeds
mentioned in commit 61336f46
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label