Update Environment setting page to use GraphQl for updating data
What does this MR do and why?
As part of allowing to select an agent in the Environment page, this MR updates the edit_environment
component to use GraphQl to update environment data.
Screenshots or screen recordings
No visual changes, the screenshot for the context:
How to set up and validate locally
- Visit Project -> Build -> Environments page
- Create an environment using the UI
- Update the environment
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Review progress:
Related to #396407 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @anna_vovchenko
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tarun Vellishetty (
@tvellishetty
) (UTC+5.5, 2.5 hours ahead of@anna_vovchenko
)Matthias Käppler (
@mkaeppler
) (UTC+2, 1 hour behind@anna_vovchenko
)frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5, 2.5 hours ahead of@anna_vovchenko
)Himanshu Kapoor (
@himkp
) (UTC+2, 1 hour behind@anna_vovchenko
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancerefactor label
added typemaintenance label and removed typefeature label
added 6 commits
-
7d820cf1...7f468448 - 5 commits from branch
396407-allow-to-select-agent-in-environment-setting-page
- 949a3f16 - Use GraphQl to update environment info
-
7d820cf1...7f468448 - 5 commits from branch
removed backend label
removed blocked label
mentioned in issue #396407 (closed)
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for de2d328fexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 0 | 23 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for de2d328fexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Govern | 21 | 0 | 0 | 1 | 21 | ❗ | | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 151 | 0 | 7 | 1 | 158 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for de2d328fexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 104 | 0 | 10 | 0 | 114 | ✅ | | Fulfillment | 4 | 0 | 50 | 0 | 54 | ✅ | | Plan | 150 | 0 | 0 | 4 | 150 | ❗ | | Manage | 64 | 0 | 6 | 2 | 70 | ❗ | | Govern | 90 | 0 | 2 | 4 | 92 | ❗ | | Create | 262 | 0 | 44 | 2 | 306 | ❗ | | Data Stores | 68 | 0 | 0 | 0 | 68 | ✅ | | Monitor | 16 | 0 | 4 | 0 | 20 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Release | 12 | 0 | 0 | 0 | 12 | ✅ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Secure | 4 | 0 | 18 | 0 | 22 | ✅ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 778 | 0 | 154 | 12 | 932 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Tristan Read
@ankit.panchal, could you please do the initial round of the frontend review?
added workflowready for review label and removed workflowin dev label
requested review from @ankit.panchal
@ankit.panchal
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @tristan.read and removed review request for @ankit.panchal
marked the checklist item frontend developer review as completed
- A deleted user
added backend feature flag labels
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e1ca234a
- Resolved by Anna Vovchenko
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@accaf586
added 508 commits
-
fb627307...205250e4 - 505 commits from branch
master
- b937d238 - Use GraphQl to update environment info
- 39ff93f9 - Use feature flag for the environment update
- ad989bdd - Update milestone for the feature flag
Toggle commit list-
fb627307...205250e4 - 505 commits from branch
added workflowin review label and removed workflowready for review label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e4a575fe
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits d5098e26 and de2d328f
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.06 MB 4.06 MB - 0.0 % mainChunk 2.88 MB 2.88 MB - 0.0 %
Note: We do not have exact data for d5098e26. So we have used data from: 88996987.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 127 commits
-
ad989bdd...834b3f3c - 124 commits from branch
master
- 3525472d - Use GraphQl to update environment info
- 8828817c - Use feature flag for the environment update
- de2d328f - Update milestone for the feature flag
Toggle commit list-
ad989bdd...834b3f3c - 124 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@1a52a671
enabled an automatic merge when the pipeline for 2044967d succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@2044967d
mentioned in commit 577b2e71
marked the checklist item frontend maintainer review as completed
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-com/www-gitlab-com#32488 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)