Skip to content

Fix migration specs leaving rows after running

Simon Tomlinson requested to merge fix-migration-testing-leaves-rows into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Fix migration specs leaving rows after running

Rather than using transactional tests, migration testing migrates the database up after each test, and manually cleans each table.

This could pollute rows into the postgres_async_foreign_key_validations table during a test run, since migrating up happened after cleaning all tables.

Instead, clean tables after migrating to delete these rows.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports