Labels as a facet - minor visual updates - part 2
What does this MR do and why?
Related to #369541 (closed)
This MR is adding one small missing piece to connect the frontend part of the labels filter to the backend. Allows to filter the results based on the filter attr in the URL. I also used this MR to help reorganize and rename some files and methods in preparation for the follow-up MRs.
| parts | status |
|---|---|
| Labels as a facet - backend tweaks - part 1 | merged |
| Labels as a facet - minor visual updates - part 2 | merged |
| Labels as a facet - state update - part 3 | merged |
| Labels as a facet - new component - part 4 | in review |
Screenshots or screen recordings
| before | after |
|---|---|
 |
 |
 |
 |
How to set up and validate locally
- Enable ff
Feature.enable(:search_issue_label_aggregation) - set up gdk for elasticsearch
- enable advanced search and index everything
- find a project where you have issues
- create a project label
- add the label to one of the issues
- find the label id of the newly created label (below assumes the id is 77):
Project.find(7).labels - http://gdk.test:3000/search?scope=issues&search=*&labels%5B%5D=77
- This should limit results to only issues containing tag id 77
Note: this MR contains only the backend changes so you will not be able to interact with this using the frontend (only through the URL params)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Tomas Bulva