Skip to content

Improve styles of Rails-rendered broadcast messages

Thomas Hutterer requested to merge thutterer/paper-cut-haml-broadcast-notification-styles into master

What does this MR do and why?

This tweaks the Haml that renders our broadcast messages to use the gl- CSS classes from our GlBroadcastMessage Vue component, to fix its styling. See the before/after screenshots.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  • Create a broadcast message (of type notification) at http://gdk.test:3000/admin/broadcast_messages
  • Set its dates so that it's actually rendered on every page.
  • Compare it with its Vue-rendered preview.
  • You can write markdown in the message. Try adding a link and or bold text. Links are blue now :)
  • Also create a banner message, check its preview and render, just to make sure nothing changed there.
  • Actually, it's dismiss button's margin got changed to look like in the preview ;)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Hutterer

Merge request reports