Skip to content

Use namespace_aggregation_schedule_lease_duration to get lease

Suraj Tripathi requested to merge issue_370251_use_app_setting_for_lease into master

What does this MR do and why?

We have made another attempt to reduce the lease duration for Namespace::AggregationSchedule. After several iterations, we have managed to reduce the lease duration to 2 minutes, with the feature flag enabled for gitlab-org on production. However, we have decided to wait back on the rollout of the feature flag with a 2-minute lease duration due to monitoring the rollout. Based on the analysis in this thread, we have realized that the ContainerRegistryAPI cannot handle the increased load that might result from fully rolling out the feature flag with a 2-minute lease duration. Therefore, we have decided to increase the lease duration to 5 minutes and monitor the situation. We have also decided to do this via application_setting, which will allow us to make adjustments to the lease duration if the load results in uncertain situations with the ContainerRegistry API.

  • The base MR adds the Application Setting
  • This MR uses the Application Setting for returning the lease duration

On production FF reduce_aggregation_schedule_lease is enabled only for gitlab-org

ref: https://gitlab.com/gitlab-org/gitlab/-/issues/370251

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Suraj Tripathi

Merge request reports