Skip to content

Add delete option to selected approvers

Andrew Fontaine requested to merge afontaine/385657/frontend into master

What does this MR do and why?

Instead of making users open the approvers dropdown and deselecting options, it is a lot smoother to have a small trash button next to each approver row to remove it from the selected options.

Changelog: added

Add two-way data binding to access dropdown

Currently, the dropdown only allows the pre-selecting of items, but in the new protected environments forms, we need it to be able to handle changes to its selected items from outside the component.

Here, we watch a data-bound array, and, on changes, we map its data to the selected items.

Screenshots or screen recordings

Screen_Recording_2023-05-16_at_10.19.44_AM

How to set up and validate locally

  1. Navigate to a project's Settings > CI/CD
  2. While creating a protected environment, play with the approvers dropdown and trash button.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

For #385657 (closed)

Edited by Andrew Fontaine

Merge request reports