Skip to content
Snippets Groups Projects

Fix GroupActivityCard relative metric links

Merged Alex Pennells requested to merge 411315-fix-relative-url-root into master
All threads resolved!

What does this MR do and why?

Account for a custom relative_url_root when generating metric links on the Group page.

Screenshot_2023-05-15_at_3.50.58_PM

How to set up and validate locally

  1. Set relative_url_root to /path:
gdk config set relative_url_root /path
gdk reconfigure
gdk restart
  1. Visit any group page: http://gdk.test:3000/path/flightjs
  2. Validate that the metric links are working as expected

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #411315 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • removed review request for @pgascouvaillancourt

  • Alex Pennells added 1 commit

    added 1 commit

    • d916229d - Generate paths on the backend

    Compare with previous version

  • requested review from @pgascouvaillancourt

  • A deleted user added backend label

    added backend label

  • Paul Gascou-Vaillancourt approved this merge request

    approved this merge request

  • Paul Gascou-Vaillancourt resolved all threads

    resolved all threads

  • Paul Gascou-Vaillancourt enabled an automatic merge when the pipeline for e30a7160 succeeds

    enabled an automatic merge when the pipeline for e30a7160 succeeds

  • mentioned in commit d6ec7ab8

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading