Skip to content

Adding JobKind: BUILD to failed jobs query

Max Fan requested to merge 407277-using-jobKind-for-graphQL-query into master

What does this MR do and why?

Important: Only merge in %16.1 for Compatibility issues

Currently the failed Jobs page will show both failed CI Build Jobs and CI Bridge jobs (Triggers). This is a regression as we only want to show Build jobs.

The graphQL resolver was added in a previous MR: !119569 (merged)

Screenshots or screen recordings

Currently

image image

After the fix:

image image

How to set up and validate locally

  1. Create a pipeline that has both failing Build and Trigger jobs
  2. Sample CI
stages:          # List of stages for jobs, and their order of execution
  - test
  - deploy

lint-test-job:   # This job also runs in the test stage.
  stage: test    # It can run at the same time as unit-test-job (in parallel).
  script:
    - unknown_command

trigger_job:
  stage: deploy
  trigger:
    include:
      - local: Child/child-pipelinez.yml
  1. the failed jobs tab should only list the lint-test-job and not the trigger_job

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #407277 (closed)

Edited by Max Fan

Merge request reports