Skip to content

Fix gitaly keys moving to instrumentation storage

Matthias Käppler requested to merge 410822-fix-gitaly-client-keys into master

What does this MR do and why?

In !119765 (merged) we moved instrumentation counters from SafeRequestStore to InstrumentationStorage. Both still use the same thread-local storage underneath, but the latter packs all instrumentation counters into a dedicated instrumentation bucket.

In that MR, some keys used by Gitaly accidentally moved to this new bucket when they are not actually instrumentation data, but used to make decisions about application behavior. Because we were reading them elsewhere from SafeRequestStore, they would always come back blank.

This is fixed here. Not user facing because this was never deployed/released.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #410822 (closed)

Merge request reports