Skip to content

Move new group name input field fully into javascript and polish form

Doug Stull requested to merge 393969-move-group-name-input-into-vue into master

What does this MR do and why?

  • Move new group name input field fully into javascript
    • reduce duplication and confusion
  • Improved bottom margin on error alert
  • Matched the group name input field width with the one used on normal group creation form.
  • Expanded submit button on mobile
  • Populate the name input on error

Screenshots or screen recordings

before after
Screenshot_2023-05-12_at_2.39.44_PM Screenshot_2023-05-12_at_2.48.36_PM
Screenshot_2023-05-12_at_3.13.36_PM Screenshot_2023-05-12_at_3.13.02_PM

How to set up and validate locally

note covered by feature specs in ee/spec/features/trials/saas

  1. Setup to simulate SaaS and restart GDK
  2. Go to /-/trials/select
  3. Simulate failures(by using @ to start name of group) and selecting.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #393969 (closed)

Edited by Doug Stull

Merge request reports