Adds a separator above the settings menu
What does this MR do and why?
This adds the separator above the Settings menu (for the new sidebar) under the Project, Group and Admin scopes
How to check and validate locally
Make sure to enable the new sidebar if it is no enabled for you:
- Enable the feature flag:
echo "Feature.enable(:super_sidebar_nav)" | rails c
- Enable the user setting from the user dropdown:
After
- Go to the project page, check that the
Settings
menu has a separator above it - Go to the group page, check that the
Settings
menu has a separator above it - Go to the admin page, check that the
Settings
menu has a separator above it
Screenshots or screen recordings
Admin | Project | Group |
---|---|---|
![]() |
![]() |
![]() |
How to set up and validate locally
Related to #410527 (closed)
Merge request reports
Activity
changed milestone to %16.0
assigned to @ohoral
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
1 Warning ⚠ a00efd48: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Gregory Havenga (
@ghavenga
) (UTC+2, 1 hour behind@ohoral
)Ethan Urie (
@eurie
) (UTC-4, 7 hours behind@ohoral
)frontend Artur Fedorov (
@arfedoro
) (UTC+2, 1 hour behind@ohoral
)Alexander Turinske (
@aturinske
) (UTC+9, 6 hours ahead of@ohoral
)UX Libor Vanc (
@lvanc
) (UTC-10, 13 hours behind@ohoral
)Maintainer review is optional for UX ~"Manage::Foundations" Reviewer review is optional for ~"Manage::Foundations" Lukas Eipert (
@leipert
) (UTC+2, 1 hour behind@ohoral
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits d3baaee6 and a00efd48
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.03 MB 4.03 MB - 0.0 % mainChunk 2.88 MB 2.88 MB - 0.0 %
Note: We do not have exact data for d3baaee6. So we have used data from: 67a14387.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
❗ test report for a00efd48expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Govern | 24 | 0 | 0 | 1 | 24 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 154 | 0 | 7 | 1 | 161 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Fabio Pitino
- Resolved by Fabio Pitino
- Resolved by Fabio Pitino
@thutterer @jrushford @aregnery would you do backend frontend and UX review respectively, please?
we aim to merge this before May 18th. Otherwise it can get in
16.2
requested review from @thutterer, @jrushford, and @aregnery
removed workflowin dev label
added workflowin review label
- Resolved by Olena Horal-Koretska
- Resolved by Olena Horal-Koretska
removed review request for @jrushford
👋 @jrushford
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @aregnery
added 444 commits
-
fb82b9f3...04b4da1c - 443 commits from branch
master
- c79f88ae - Add separator above the settings menu
-
fb82b9f3...04b4da1c - 443 commits from branch
requested review from @fabiopitino and @f_caplette and removed review request for @thutterer
- Resolved by Olena Horal-Koretska
- Resolved by Fabio Pitino
- Resolved by Frédéric Caplette
mentioned in issue #411461 (closed)
- Resolved by Olena Horal-Koretska
@ohoral could you resolve the merge conflicts?
added 130 commits
-
c79f88ae...2597cc1b - 129 commits from branch
master
- a00efd48 - Add separator above the settings menu
-
c79f88ae...2597cc1b - 129 commits from branch
enabled an automatic merge when the pipeline for d2c0d8a6 succeeds
mentioned in commit 257fd717
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-staging label and removed workflowproduction label
mentioned in issue gitlab-org/manage/foundations/team-tasks#257