Skip to content
Snippets Groups Projects

Adds a separator above the settings menu

Merged Olena Horal-Koretska requested to merge 410527-add-separator-above-settings into master
All threads resolved!

What does this MR do and why?

This adds the separator above the Settings menu (for the new sidebar) under the Project, Group and Admin scopes

How to check and validate locally

Make sure to enable the new sidebar if it is no enabled for you:

  1. Enable the feature flag:
echo "Feature.enable(:super_sidebar_nav)" | rails c
  1. Enable the user setting from the user dropdown:

Screenshot_2022-12-13_at_1.32.43_PM

After

  1. Go to the project page, check that the Settings menu has a separator above it
  2. Go to the group page, check that the Settings menu has a separator above it
  3. Go to the admin page, check that the Settings menu has a separator above it

Screenshots or screen recordings

Admin Project Group
admin project group

How to set up and validate locally

Related to #410527 (closed)

Edited by Olena Horal-Koretska

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Olena Horal-Koretska
  • requested review from @thutterer, @jrushford, and @aregnery

  • added 1 commit

    • 278920c0 - Add separator above the settings menu

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • James Rushford approved this merge request

    approved this merge request

  • James Rushford removed review request for @jrushford

    removed review request for @jrushford

  • 👋 @jrushford, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Thomas Hutterer approved this merge request

    approved this merge request

  • Austin Regnery approved this merge request

    approved this merge request

  • Austin Regnery removed review request for @aregnery

    removed review request for @aregnery

  • Olena Horal-Koretska added 444 commits

    added 444 commits

    Compare with previous version

  • Olena Horal-Koretska requested review from @fabiopitino and @f_caplette and removed review request for @thutterer

    requested review from @fabiopitino and @f_caplette and removed review request for @thutterer

  • Olena Horal-Koretska changed the description

    changed the description

  • Frédéric Caplette
  • Frédéric Caplette
  • Frédéric Caplette approved this merge request

    approved this merge request

  • Fabio Pitino approved this merge request

    approved this merge request

  • Fabio Pitino resolved all threads

    resolved all threads

  • mentioned in issue #411461 (closed)

  • Fabio Pitino resolved all threads

    resolved all threads

  • Olena Horal-Koretska added 130 commits

    added 130 commits

    Compare with previous version

  • Olena Horal-Koretska resolved all threads

    resolved all threads

  • Frédéric Caplette enabled an automatic merge when the pipeline for d2c0d8a6 succeeds

    enabled an automatic merge when the pipeline for d2c0d8a6 succeeds

  • mentioned in commit 257fd717

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading