Skip to content
Snippets Groups Projects

Migrate GlDropdown to GlListbox in severity filter

Merged David Pisek requested to merge 409701-migrate-severity_filter-to-listbox into master
All threads resolved!

What does this MR do and why?

Uses GlListbox instead of GlDropdown within the severity filter UI component, which is used on security reports pages.

Screenshots or screen recordings

Screenshots

before after
Screenshot_2023-05-12_at_9.13.26_am default-after
Screenshot_2023-05-12_at_9.13.35_am multiple-after

Recordings

before after
Screen Recording 2023-05-12 at 9.15.43 am.mov Screen Recording 2023-05-12 at 9.16.18 am.mov

How to set up and validate locally

TODO

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #409701 (closed)

Edited by David Pisek

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Pisek
  • David Pisek added 1 commit

    added 1 commit

    • 8bedbd6f - Migrate GlDropdown to GlListbox in severity filter

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    • 23c322b8 - Migrate GlDropdown to GlListbox in severity filter

    Compare with previous version

  • Contributor
    1 Warning
    :warning: This merge request does not refer to an existing milestone.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend Sharmad Nachnolkar current availability (@snachnolkar) (UTC+5.5, 3.5 hours ahead of @dpisek) Alexander Turinske current availability (@aturinske) (UTC+9, 7 hours ahead of @dpisek)
    UX Sascha Eggenberger current availability (@seggenberger) (UTC+2, same timezone as @dpisek) Maintainer review is optional for UX

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 85b6f3de and eed0dd99

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.05 MB 4.05 MB +1.96 KB 0.0 %
    mainChunk 2.88 MB 2.88 MB - 0.0 %

    :fearful: Significant Growth: 7

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.projects.pipelines.builds 2.03 MB 2.16 MB +133.5 KB 6.4 %
    pages.projects.pipelines.codequality_report 2.03 MB 2.16 MB +133.5 KB 6.4 %
    pages.projects.pipelines.dag 2.03 MB 2.16 MB +133.5 KB 6.4 %
    pages.projects.pipelines.failures 2.03 MB 2.16 MB +133.5 KB 6.4 %
    pages.projects.pipelines.licenses 2.03 MB 2.16 MB +133.5 KB 6.4 %
    pages.projects.pipelines.security 2.03 MB 2.16 MB +133.5 KB 6.4 %
    pages.projects.pipelines.show 2.03 MB 2.16 MB +133.5 KB 6.4 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@leipert, @markrian, @ohoral or @pgascouvaillancourt) for review, if you are unsure about the size increase.

    Note: We do not have exact data for 85b6f3de. So we have used data from: f95b16e2.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • David Pisek added 1 commit

    added 1 commit

    • c51a3a54 - Migrate GlDropdown to GlListbox in severity filter

    Compare with previous version

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for eed0dd99

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Verify           | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
    | Plan             | 50     | 0      | 1       | 0     | 51    | ✅     |
    | Govern           | 21     | 0      | 0       | 1     | 21    | ❗     |
    | Create           | 27     | 0      | 1       | 0     | 28    | ✅     |
    | Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
    | Manage           | 8      | 0      | 3       | 0     | 11    | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 151    | 0      | 7       | 1     | 158   | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-gdk: :white_check_mark: test report for eed0dd99

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 0     | 23    | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • David Pisek added 117 commits

    added 117 commits

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    • 1985485b - Migrate GlDropdown to GlListbox in severity filter

    Compare with previous version

  • David Pisek changed the description

    changed the description

  • David Pisek changed the description

    changed the description

  • David Pisek added 1 commit

    added 1 commit

    • 6ddfed63 - Migrate GlDropdown to GlListbox in severity filter

    Compare with previous version

  • David Pisek marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • David Pisek requested review from @dftian

    requested review from @dftian

  • David Pisek marked this merge request as ready

    marked this merge request as ready

  • Author Maintainer

    @beckalippert - Could you please review the UX changes? :bow:

  • David Pisek requested review from @beckalippert

    requested review from @beckalippert

  • David Pisek added 111 commits

    added 111 commits

    Compare with previous version

  • Daniel Tian
  • Daniel Tian
  • Daniel Tian
  • Daniel Tian
  • Daniel Tian
  • Daniel Tian
  • David Pisek added 206 commits

    added 206 commits

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    • b30bac82 - Review feedback: remove slot content

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    • 8af311cd - Review feedback: simplify watchers

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    • c58b50a0 - Review feedback: remove unnused i18n

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    Compare with previous version

  • David Pisek
  • David Pisek added 1 commit

    added 1 commit

    Compare with previous version

  • David Pisek added 270 commits

    added 270 commits

    Compare with previous version

  • Daniel Tian approved this merge request

    approved this merge request

  • :wave: @dftian, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Becka Lippert approved this merge request

    approved this merge request

  • David Pisek added 761 commits

    added 761 commits

    Compare with previous version

  • David Pisek added 17 commits

    added 17 commits

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    • 5a3fcca9 - Refactor: Leverage improved helper

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    • 27aaff8d - Revert change to querystring-sync

    Compare with previous version

  • David Pisek requested review from @svedova

    requested review from @svedova

  • Savas Vedova approved this merge request

    approved this merge request

  • Savas Vedova resolved all threads

    resolved all threads

  • Savas Vedova enabled an automatic merge when the pipeline for 006abd0b succeeds

    enabled an automatic merge when the pipeline for 006abd0b succeeds

  • Savas Vedova
  • David Pisek aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • David Pisek added 56 commits

    added 56 commits

    • 27aaff8d...440cb446 - 48 commits from branch master
    • 67f876d7 - Migrate GlDropdown to GlListbox in severity filter
    • f4307f21 - Review feedback: remove slot content
    • c81df68e - Review feedback: simplify watchers
    • 83f376fb - Review feedback: remove unnused i18n
    • b593020e - Fix failing specs
    • a2f172e3 - Refactor: Leverage improved helper
    • 46083cfd - Revert change to querystring-sync
    • 9dbe8e35 - Review feedback: remove css class

    Compare with previous version

  • David Pisek resolved all threads

    resolved all threads

  • David Pisek added 74 commits

    added 74 commits

    • 9dbe8e35...35ee2da3 - 66 commits from branch master
    • e6c5da36 - Migrate GlDropdown to GlListbox in severity filter
    • 0761782c - Review feedback: remove slot content
    • ebe944b3 - Review feedback: simplify watchers
    • 6acefc51 - Review feedback: remove unnused i18n
    • c5b391c1 - Fix failing specs
    • 10398023 - Refactor: Leverage improved helper
    • f5883219 - Revert change to querystring-sync
    • 9d9f205e - Review feedback: remove css class

    Compare with previous version

  • David Pisek added 90 commits

    added 90 commits

    • 9d9f205e...85b6f3de - 82 commits from branch master
    • cb46e0f7 - Migrate GlDropdown to GlListbox in severity filter
    • c3589092 - Review feedback: remove slot content
    • bb8d2e65 - Review feedback: simplify watchers
    • cb3d4f90 - Review feedback: remove unnused i18n
    • 2eea9405 - Fix failing specs
    • a87e115f - Refactor: Leverage improved helper
    • c15b7d7f - Revert change to querystring-sync
    • eed0dd99 - Review feedback: remove css class

    Compare with previous version

  • Savas Vedova approved this merge request

    approved this merge request

  • Savas Vedova resolved all threads

    resolved all threads

  • Savas Vedova enabled an automatic merge when the pipeline for 8df2ac4b succeeds

    enabled an automatic merge when the pipeline for 8df2ac4b succeeds

  • merged

  • Savas Vedova mentioned in commit 6696ced7

    mentioned in commit 6696ced7

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading