Migrate GlDropdown to GlListbox in severity filter
What does this MR do and why?
Uses GlListbox
instead of GlDropdown
within the severity filter UI component, which is used on security reports pages.
Screenshots or screen recordings
Screenshots
before | after |
---|---|
![]() |
![]() |
![]() |
![]() |
Recordings
before | after |
---|---|
Screen Recording 2023-05-12 at 9.15.43 am.mov | Screen Recording 2023-05-12 at 9.16.18 am.mov |
How to set up and validate locally
TODO
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #409701 (closed)
Merge request reports
Activity
assigned to @dpisek
- Resolved by Savas Vedova
- Resolved by Savas Vedova
added 1 commit
- 8bedbd6f - Migrate GlDropdown to GlListbox in severity filter
added 1 commit
- 23c322b8 - Migrate GlDropdown to GlListbox in severity filter
1 Warning This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Sharmad Nachnolkar (
@snachnolkar
) (UTC+5.5, 3.5 hours ahead of@dpisek
)Alexander Turinske (
@aturinske
) (UTC+9, 7 hours ahead of@dpisek
)UX Sascha Eggenberger (
@seggenberger
) (UTC+2, same timezone as@dpisek
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 85b6f3de and eed0dd99
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.05 MB 4.05 MB +1.96 KB 0.0 % mainChunk 2.88 MB 2.88 MB - 0.0 % Significant Growth: 7Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.pipelines.builds 2.03 MB 2.16 MB +133.5 KB 6.4 % pages.projects.pipelines.codequality_report 2.03 MB 2.16 MB +133.5 KB 6.4 % pages.projects.pipelines.dag 2.03 MB 2.16 MB +133.5 KB 6.4 % pages.projects.pipelines.failures 2.03 MB 2.16 MB +133.5 KB 6.4 % pages.projects.pipelines.licenses 2.03 MB 2.16 MB +133.5 KB 6.4 % pages.projects.pipelines.security 2.03 MB 2.16 MB +133.5 KB 6.4 % pages.projects.pipelines.show 2.03 MB 2.16 MB +133.5 KB 6.4 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for 85b6f3de. So we have used data from: f95b16e2.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- c51a3a54 - Migrate GlDropdown to GlListbox in severity filter
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for eed0dd99expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Govern | 21 | 0 | 0 | 1 | 21 | ❗ | | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 151 | 0 | 7 | 1 | 158 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for eed0dd99expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 0 | 23 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 117 commits
-
c51a3a54...48071ab8 - 116 commits from branch
master
- 563453ac - Migrate GlDropdown to GlListbox in severity filter
-
c51a3a54...48071ab8 - 116 commits from branch
added 1 commit
- 1985485b - Migrate GlDropdown to GlListbox in severity filter
added 1 commit
- 6ddfed63 - Migrate GlDropdown to GlListbox in severity filter
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @dftian
- Resolved by Savas Vedova
@dftian - Could you please do the initial review?
@beckalippert - Could you please review the UX changes?
requested review from @beckalippert
added 111 commits
-
6ddfed63...6df382d9 - 110 commits from branch
master
- 4bbedec3 - Migrate GlDropdown to GlListbox in severity filter
-
6ddfed63...6df382d9 - 110 commits from branch
- Resolved by David Pisek
- Resolved by David Pisek
- Resolved by David Pisek
- Resolved by David Pisek
- Resolved by David Pisek
- Resolved by David Pisek
added 206 commits
-
4bbedec3...44865a2c - 205 commits from branch
master
- 5c676437 - Migrate GlDropdown to GlListbox in severity filter
-
4bbedec3...44865a2c - 205 commits from branch
- Resolved by Savas Vedova
added 270 commits
Toggle commit list@dftian
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added 761 commits
Toggle commit listadded 17 commits
Toggle commit listrequested review from @svedova
enabled an automatic merge when the pipeline for 006abd0b succeeds
- Resolved by David Pisek
added 56 commits
-
27aaff8d...440cb446 - 48 commits from branch
master
- 67f876d7 - Migrate GlDropdown to GlListbox in severity filter
- f4307f21 - Review feedback: remove slot content
- c81df68e - Review feedback: simplify watchers
- 83f376fb - Review feedback: remove unnused i18n
- b593020e - Fix failing specs
- a2f172e3 - Refactor: Leverage improved helper
- 46083cfd - Revert change to querystring-sync
- 9dbe8e35 - Review feedback: remove css class
Toggle commit list-
27aaff8d...440cb446 - 48 commits from branch
added 74 commits
-
9dbe8e35...35ee2da3 - 66 commits from branch
master
- e6c5da36 - Migrate GlDropdown to GlListbox in severity filter
- 0761782c - Review feedback: remove slot content
- ebe944b3 - Review feedback: simplify watchers
- 6acefc51 - Review feedback: remove unnused i18n
- c5b391c1 - Fix failing specs
- 10398023 - Refactor: Leverage improved helper
- f5883219 - Revert change to querystring-sync
- 9d9f205e - Review feedback: remove css class
Toggle commit list-
9dbe8e35...35ee2da3 - 66 commits from branch
added 90 commits
-
9d9f205e...85b6f3de - 82 commits from branch
master
- cb46e0f7 - Migrate GlDropdown to GlListbox in severity filter
- c3589092 - Review feedback: remove slot content
- bb8d2e65 - Review feedback: simplify watchers
- cb3d4f90 - Review feedback: remove unnused i18n
- 2eea9405 - Fix failing specs
- a87e115f - Refactor: Leverage improved helper
- c15b7d7f - Revert change to querystring-sync
- eed0dd99 - Review feedback: remove css class
Toggle commit list-
9d9f205e...85b6f3de - 82 commits from branch
enabled an automatic merge when the pipeline for 8df2ac4b succeeds
mentioned in commit 6696ced7
added workflowstaging-canary label and removed workflowrefinement label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)