Skip to content

Remove FF `always_perform_delayed_deletion`

Manoj M J [PTO - Back on 17th June] requested to merge 393622-feature-flag-rollout-of-always_perform_delayed_deletion-remove into master

What does this MR do and why?

Related to #393622 (closed)

Now that the always_perform_delayed_deletion has been enabled by default for a few days, we can remove this feature flag.

Follow up issue: #411206 (closed), to drop the columns related to delayed deletion, since they are no longer used.

Screenshots or screen recordings

Admin area

feature flag disabled feature flag enabled feature flag removed (this MR)
Screenshot_2023-05-11_at_3.57.01_PM Screenshot_2023-05-11_at_3.56.05_PM Screenshot_2023-05-15_at_10.30.46_AM

How to set up and validate locally

  1. Go to /admin/application_settings/general and expand the Visibility and access controls section. There should be only an input for retention period.
  2. Go to a group -> Settings -> General -> Permissions and group features. The Deletion protection setting shouldn't be rendered.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Manoj M J [PTO - Back on 17th June]

Merge request reports