Skip to content

Allow up to 10 files in cache key

Fred Coxrequested to merge
mcfedr/gitlab:more-cache-files into master

What does this MR do and why?

Increase the number of files allowed to be used in creating the cache key for a ci job.

The limit is currently 2, and this changes it to 10.

Why 10? its more than 2 but still not too many... not sure what logic should apply here. I can see a request to gitaly is made for each file, to find its last commit, so i guess makes sense to not have a very long list.

Checklist

  • As far as I can see, the cache key is later caluclated looping over the array of files, so no further changes should be required to make this change. Can see this in lib/gitlab/ci/pipeline/seed/build/cache.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Fixes #301161

Edited by Fred Cox

Merge request reports