Skip to content

Remove specs from Verify CODEOWNERS section

Fabio Pitino requested to merge remove-specs-from-verify-codeowners into master

What does this MR do and why?

In some occasions like !120244 (merged) the MR requires Verify backend approval because they modified various specs and that touches Verify rules from CODEOWNERS section.

Specs can be edited for several reasons like quarantine from Quality team and general improvements suggested by Rubocop. We don't want to block reviews with mandatory approval on such cases.

We consciously took a conservative approach when we first committed Verify required approval so we could validate whether approving specs would be a bottle neck.

With Enforce domain expert approval in critical CI a... (#393864 - closed) the primary problem we wanted to solve was lack of visibility in production code changes which can lead to bugs and technical debt, not necessarily spec changes.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Fabio Pitino

Merge request reports