Revert "Merge branch '388156-read-vuln-custom-role' into 'master'"
What does this MR do and why?
This reverts merge request !114734 (merged) due to a performance issue (caught on canary, only for some groups and group owner
s).
The problem is caused by Member.elevated_guests
method. The performance issue is new even though there was no change to this method or related queries. The reason is that before adding read_vulnerabilities
to custom roles, we had only read_code
permission for custom roles which is excluded from the elevating_permissions
.
We need to put elevated_guests
under a FF and long-term we need to fix the performance issue.
Db migration
In the original MR there was a migration that added a new column. Revert of this migration is not included as that didn't cause any issues and the migration will be finished on the production once this one gets there.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.