Skip to content

Update settings labels to use MiB instead of MB titles

Kos Palchyk requested to merge 407872-fe-detailed-visibility-update-settings-labels-to-use-mib-instead-of-mb-titles into master

What does this MR do and why?

Updates limit labels to use power-of-2 notations instead of power-of-10 ones. Resolves #407872.

This is a part of the transition to power-of-2 labels, continuation after Use power-of-2 labels (!120333 - merged). For more details on why we're transitioning to MiB, please see these SPIKE results https://gitlab.com/gitlab-org/gitlab/-/issues/391546#note_1313262374. This MR doesn't change any underlying math of how we calculate the limits, it changes only the labels we use.

I limited this MR changes to just label updates (allowed myself only one non-haml update, I added a dedicated note on that).

Screenshots or screen recordings

Admin settings (e.g. http://localhost:3000/admin/application_settings/general) image
Group settings (e.g. http://localhost:3000/groups/gitlab-org/-/edit) image
Project settings (e.g. http://localhost:3000/gitlab-org/test-ci/edit) image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kos Palchyk

Merge request reports