Skip to content

Lock tables before dropping the LFK trigger

Marius Bobin requested to merge mb-table-partition-helper-locking-fix into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Lock tables before dropping the LFK trigger

Removing the LFK trigger will access exclusively lock the table and that table might not be the first one to be locked for attaching it as a partition.

This changed the locking order for partitioning ci_builds by locking the builds table before the pipelines which resulted in deadlocks.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Marius Bobin

Merge request reports