Mark project as CI resource
What does this MR do and why?
Implements #407249 (closed)
Design issue: #396836 (closed)
This MR allows a user to mark a project as a CI Catalog resource.
Screenshots or screen recordings
without feature flag | with feature flag | modal | toggled/disabled |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Enable the feature flag
Feature.enable(:ci_namespace_catalog_experimental)
- Create a new project in GDK. Make sure to add a project description
- Navigate to Settings >> General and expand Visibility, project features, permissions
- Below "Releases", you will see the option to mark your project as a CI catalog resource
- Observe that upon toggling this option, the toggle is disabled as this change is currently irreversible.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.0
assigned to @bsandlin
5 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request is quite big (505 lines changed), please consider splitting it into multiple merge requests. 2510900d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 6b4b62a1: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/ci/components/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Joseph Joshua (
@joseph
) (UTC+0, 5 hours ahead of@bsandlin
)Kerri Miller (
@kerrizor
) (UTC-5, same timezone as@bsandlin
)frontend Stanislav Lashmanov (
@slashmanov
) (UTC+4, 9 hours ahead of@bsandlin
)Eduardo Sanz-Garcia (
@eduardosanz
) (UTC+2, 7 hours ahead of@bsandlin
)UX Matthew Nearents (
@mnearents
) (UTC-7, 2 hours behind@bsandlin
)Maintainer review is optional for UX ~"Verify" Reviewer review is optional for ~"Verify" Stan Hu (
@stanhu
) (UTC-7, 2 hours behind@bsandlin
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5d7b1dc1 and f8614230
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.12 MB 4.12 MB - 0.0 % mainChunk 2.98 MB 2.98 MB - 0.0 % Significant Growth: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.edit 614.41 KB 630.98 KB +16.57 KB 2.7 % pages.projects.shared.permissions 225.55 KB 242.12 KB +16.57 KB 7.3 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for 5d7b1dc1. So we have used data from: 84e6f779.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for f8614230expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 30 | 0 | 3 | 1 | 33 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for f8614230expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for dc086f3eexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 385 | 0 | 3 | 8 | 388 | ❗ | | Create | 678 | 0 | 112 | 12 | 790 | ❗ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Verify | 255 | 0 | 25 | 0 | 280 | ✅ | | Package | 150 | 0 | 18 | 141 | 168 | ❗ | | Manage | 214 | 10 | 17 | 5 | 241 | ❌ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Govern | 240 | 0 | 5 | 20 | 245 | ❗ | | Fulfillment | 12 | 0 | 125 | 0 | 137 | ✅ | | Data Stores | 185 | 0 | 3 | 0 | 188 | ✅ | | Monitor | 52 | 0 | 11 | 0 | 63 | ✅ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | Secure | 10 | 0 | 45 | 0 | 55 | ✅ | | Systems | 19 | 0 | 0 | 8 | 19 | ❗ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2244 | 10 | 402 | 194 | 2656 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
- A deleted user
added backend label
- Resolved by Briley Sandlin
@marcel.amirault Could you please double check my copy here?
Also, do you know if we have specific links in mind for the 2 links? They look very similar and I didn't see anything in the issues.
requested review from @marcel.amirault
requested review from @mgandres
- Resolved by Briley Sandlin
@mgandres Hi there! I was wondering if you could take a look at this.
I still have to add in the hrefs and add a bit more test coverage, but we are going to try and get this into %16.0 so I am hoping that we can add in a follow up MR if needed for the last little chunk.
@f_caplette will be maintaining this.
added UX label
- Resolved by Briley Sandlin
- Resolved by Briley Sandlin
added Technical Writing UI text labels