Skip to content

Remove unused sequence from VSD table

Adam Hegyi requested to merge ah-remove-unused-sequence into master

What does this MR do and why?

This MR fixes the DB schema inconsistency where we accidentally created a sequence which was not persisted in the structure.sql file.

Related conversation: !118908 (comment 1382637371)

Since the table is empty and not used, the simplest way to solve was to re-create it (instead of invoking DROP sequence and CREATE sequence + a few other queries in the down method)

DB

Up:

main: == [advisory_lock_connection] object_id: 275380, pg_backend_pid: 49853
main: == 20230509072635 DropUnusedSequenceByRecreatingVsaTable: migrating ===========
main: -- drop_table(:value_stream_dashboard_aggregations)
main:    -> 0.0028s
main: -- create_table(:value_stream_dashboard_aggregations, {:id=>false})
main:    -> 0.0085s
main: == 20230509072635 DropUnusedSequenceByRecreatingVsaTable: migrated (0.0212s) ==

main: == [advisory_lock_connection] object_id: 275380, pg_backend_pid: 49853
ci: == [advisory_lock_connection] object_id: 275700, pg_backend_pid: 49888
ci: == 20230509072635 DropUnusedSequenceByRecreatingVsaTable: migrating ===========
ci: -- drop_table(:value_stream_dashboard_aggregations)
ci:    -> 0.0017s
ci: -- create_table(:value_stream_dashboard_aggregations, {:id=>false})
ci:    -> 0.0045s
ci: == 20230509072635 DropUnusedSequenceByRecreatingVsaTable: migrated (0.0148s) ==

ci: == [advisory_lock_connection] object_id: 275700, pg_backend_pid: 49888

Down:

main: == [advisory_lock_connection] object_id: 275160, pg_backend_pid: 48624
main: == 20230509072635 DropUnusedSequenceByRecreatingVsaTable: reverting ===========
main: -- drop_table(:value_stream_dashboard_aggregations)
main:    -> 0.0019s
main: -- create_table(:value_stream_dashboard_aggregations, {:id=>false})
main:    -> 0.0053s
main: == 20230509072635 DropUnusedSequenceByRecreatingVsaTable: reverted (0.0117s) ==

ci: == [advisory_lock_connection] object_id: 275100, pg_backend_pid: 49061
ci: == 20230509072635 DropUnusedSequenceByRecreatingVsaTable: reverting ===========
ci: -- drop_table(:value_stream_dashboard_aggregations)
ci:    -> 0.0037s
ci: -- create_table(:value_stream_dashboard_aggregations, {:id=>false})
ci:    -> 0.0065s
ci: == 20230509072635 DropUnusedSequenceByRecreatingVsaTable: reverted (0.0278s) ==

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports