Remove hover animation in links and buttons
What does this MR do and why?
Originally, this MR was to address the following:
Remove sub-nav transition animation in new sidebar
- Remove hover animation to match top-level nav items
...which ended up removing the hover animation on all links and buttons. While unintentional, the result makes the product feel quite a bit snappier than before (see examples below)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Merge request reports
Activity
changed milestone to %16.0
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
mentioned in issue #403059 (closed)
- Resolved by Austin Regnery
requested review from @aregnery
- Resolved by Ezekiel Kigbo
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Scott de Jonge (
@sdejonge
) (UTC+10, 10 hours ahead of@annabeldunstone
)Anna Vovchenko (
@anna_vovchenko
) (UTC+3, 3 hours ahead of@annabeldunstone
)UX Ali Ndlovu (
@andlovu
) (UTC+2, 2 hours ahead of@annabeldunstone
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 41bd4182 and df0075a6
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.03 MB 4.03 MB - 0.0 % mainChunk 2.88 MB 2.88 MB - 0.0 %
Note: We do not have exact data for 41bd4182. So we have used data from: 8e534f5e.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerrequested review from @mfluharty
removed review request for @aregnery
@aregnery
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for df0075a6expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Govern | 24 | 0 | 0 | 0 | 24 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Manage | 8 | 0 | 3 | 0 | 11 | ✅ | | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 154 | 0 | 7 | 0 | 161 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in issue gitlab-org/manage/foundations/team-tasks#248
- Resolved by Ezekiel Kigbo
@ekigbo Would you do the maintainer review for this please?
requested review from @ekigbo and removed review request for @mfluharty
added CSS cleanup label
added UI polish label
enabled an automatic merge when the pipeline for 54825817 succeeds
mentioned in commit f84e31e5
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2145 (merged)
added Category:Navigation & Settings label