Skip to content

Extract response service as more generic and update name

Alexandru Croitor requested to merge refactor_response_service_and_response_modifiers into master

What does this MR do and why?

This refactors ResponseService to be more generic and pass the response handling to response modifiers.

ResponseService becomes GraphqlSubscriptionResponseService and defines a response format for all ai providers.

Response modifiers on the other hand are responsible for adjusting the responses from different endpoints for each provider to fit the format defined by GraphqlSubscriptionResponseService

Also originally modifiers were passed in as an argument to GraphqlSubscriptionResponseService#execute method, now these are passed into GraphqlSubscriptionResponseService at the initialization as GraphqlSubscriptionResponseService does not really care about the response from AI provider anymore and delegates handling that to response modifiers.

Extract response service as more generic and update name

Rename ResponseService to be more specificly related to GraphQl subscription response but also extract it to not be within openAI module and more generic.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alexandru Croitor

Merge request reports