Skip to content

Fix filter token not showing up when multiple assignees are enabled

Heinrich Lee Yu requested to merge fix-search-bar-specs-ee into master

What does this MR do?

When multiple assignees are enabled, our filter bar doesn't show the assignee token when using the assignee_username param instead of assignee_username[].

This is a problem because some of our links use the singular param. For example: The "Issues assigned to me" link from the global search bar.

This MR adds the old param as an alternative token format.

We actually have specs for this but this bug wasn't caught because of false positives caused by an incorrect helper. I'm also fixing that in this MR and backporting it to CE https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27759

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports