Skip to content

Fix tab count on tab switch (jobs table/tabs)

Andreas Deicha requested to merge gitlab-community/gitlab:fix_tab_count_admin_jobs_vue into master

What does this MR do and why?

Solves #409545 (closed)

Fixes wrong job count when tab is switched in a certain way

🛠 with ❤ at Siemens

How to set up and validate locally

  1. Go to any project > CI/CD > Jobs
  2. Filter a job status, count should change accordingly.
  3. Switch to the finished tab, count stays as it is in tab all
  4. Switch to the all tab, count should be refeteched/recalculated since filter does not apply anymore.
  5. Try to reproduce what I showed in the video #409545 (closed) (ideally it should not be possible anymore)
  6. Make sure to enable FF Feature.enable(:admin_jobs_vue)
  7. Do the same for Admin > CI/CD > Jobs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports