Skip to content

Draft: Move spec setup out of `before` and into the factory

drew stachon requested to merge dc-move-logic-to-factory into master

What does this MR do and why?

Move spec setup out of before and into the factory, to simplify a spec context that I'm working in.

We have a line in the before block that simply sets some minutes attributes. We do some of this in the namespace factory already, so we can be consistent and make the setting more reusable.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Read the new code
  2. bundle exec rspec ee/spec/requests/api/namespaces_spec.rb
  3. bundle exec rspec ee/spec/features/admin/admin_groups_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by drew stachon

Merge request reports