Skip to content

Add feedback banner on runner creation page

What does this MR do and why?

This change adds a feedback banner on the new runner pages for admin, group and project areas.

The banner is dismissible and the dismissal is permanent for a given user regardless of where the dimissal occurs.

Screenshots or screen recordings

image

How to set up and validate locally

Check banner appearance

Admin

  1. Enable the feature flag: in your console rails c, and then Feature.enable(:create_runner_workflow_for_admin)
  2. Visit Admin > CI/CD > Runners e.g. http://gdk.test:3000/admin/runners
  3. Click on "New instance runner"

Group / Project

  1. Enable the feature flag: in your console rails c, and then Feature.enable(:create_runner_workflow_for_namespace)
  2. Visit a group's runners My group > CI/CD > Runners, e.g. http://gdk.test:3000/groups/top-group/-/runners
    1. Click on "New group runner"
  3. Visit a project's Settings > CI/CD > Runners, you must own the project e.g. http://gdk.test:3000/top-group/top-project/-/settings/ci_cd
    1. Click on "New project runner"

Check dismissal

  1. Dismiss the banner.
  2. Confirm that it's not present in any of the sections mentioned above
  3. Note: You may restore the banner, in your console type rails c, and then User.find(1).callouts.last.destroy (assuming you are logged in as root)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #389183 (closed)

Edited by Miguel Rincon

Merge request reports