Skip to content

Draft: `Gitlab::Database::GitlabSchema.table_schema` should take in `connection` as a parameter

Manoj M J requested to merge 408921-follow-up-from-gitlab-database-gitlabschema-table_schema-to-return-nil into master

What does this MR do and why?

This is a follow up from #408921 (closed).

Gitlab::Database::GitlabSchema.table_schema method should also take in connection as a parameter because connections can differ based on the database it is running in (main or ci). Currently, both of them have the same schema, but over time, this can change and can cause trouble. So the connection used should be explicit when figuring out the table schema of tables.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #408921 (closed)

Edited by Manoj M J

Merge request reports