Take subscription e2e test through checkout during registration
What does this MR do and why?
We want to have appropriate end-to-end test coverage for all the registration paths. This MR takes the previous registration through subscription flow spec through a successful checkout and finishes the registration flow.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #387405 (closed)
Merge request reports
Activity
4 Warnings ⚠ 59afcea3: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ 29d22507: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ 6035ff47: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ This merge request does not refer to an existing milestone. 1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Valery Sizov (
@vsizov
) (UTC+1)Rémy Coutable (
@rymai
) (UTC+2)frontend Sharmad Nachnolkar (
@snachnolkar
) (UTC+5.5)Frédéric Caplette (
@f_caplette
) (UTC-4)test for spec/features/*
Valery Sizov (
@vsizov
) (UTC+1)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Dangeradded 840 commits
-
06197bcc...3e5720d7 - 839 commits from branch
master
- 13d7cc5b - Take subscription test through checkout
-
06197bcc...3e5720d7 - 839 commits from branch
added 1488 commits
-
13d7cc5b...f89ace86 - 1487 commits from branch
master
- 72761bd4 - Take subscription test through checkout
-
13d7cc5b...f89ace86 - 1487 commits from branch
- A deleted user
added frontend label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 35d1b0dd and 4d89a5f4
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.09 MB 4.09 MB - 0.0 % mainChunk 2.95 MB 2.95 MB - 0.0 %
Note: We do not have exact data for 35d1b0dd. So we have used data from: 2c00d961.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
❗ test report for 4d89a5f4expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
❗ test report for 4d89a5f4expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- A deleted user
added backend label
- Resolved by Vitaly Slobodin
@dstull @jmontal Hey guys, could you give this an initial review?
I decided to modify the Vue component a bit for testability. We don't have any case of mocking apollo local queries in our codebase and I didn't get suggestions on how to do that from posting in the frontend channel, so want to try this approach instead.
requested review from @jmontal
requested review from @dstull
- Resolved by Doug Stull
- Resolved by Jay Montal
- Resolved by Doug Stull
added 1 commit
- 7057c53e - Skip payment iframe by calling vuex action directly
added 1 commit
- 4b935f02 - Skip payment iframe by calling vuex action directly
- Resolved by Doug Stull
- Resolved by Doug Stull
- Resolved by Vitaly Slobodin
- Resolved by Doug Stull
- Resolved by Doug Stull
- Resolved by Roy Liu
- Resolved by Doug Stull
removed review request for @dstull
removed review request for @jmontal
requested review from @dstull
- Resolved by Doug Stull
removed review request for @dstull
mentioned in issue #411592
requested review from @dstull
- Resolved by Doug Stull
- Resolved by Doug Stull
- Resolved by Doug Stull
- Resolved by Doug Stull
removed review request for @dstull
requested review from @dstull
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Doug Stull
removed review request for @dstull
- Resolved by Doug Stull
added 1197 commits
-
6e345ca3...5a35aa49 - 1194 commits from branch
master
- dc2412d7 - Take subscription test through checkout
- 093b2240 - Skip payment iframe by calling vuex action directly
- 8d6166b3 - Apply review suggestions
Toggle commit list-
6e345ca3...5a35aa49 - 1194 commits from branch
- Resolved by Doug Stull
requested review from @dstull
👋 @dstull
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @vitallium
removed review request for @dstull
added 360 commits
-
628c704e...165bcb3a - 359 commits from branch
master
- dccd150f - Merge branch 'master' into '387405-subscription-e2e-test-through-checkout-during-registration'
-
628c704e...165bcb3a - 359 commits from branch
- Resolved by Vitaly Slobodin
requested review from @dstull
removed review request for @dstull
added 634 commits
-
c84605af...1c1a068f - 630 commits from branch
master
- 6035ff47 - Take subscription test through checkout
- 29d22507 - Skip payment iframe by calling vuex action directly
- 59afcea3 - Apply review suggestions
- 258f1560 - Fix bug when ensure_onboarding is enabled
Toggle commit list-
c84605af...1c1a068f - 630 commits from branch
added 1 commit
- 4d89a5f4 - Add comment about solution for skipping zuora step in checkout
enabled an automatic merge when the pipeline for 7194e06c succeeds
changed milestone to %16.1
mentioned in commit 4adadd6f
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #387405 (closed)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label