Instance streaming audit events - add FF and tab
What does this MR do and why?
This MR adds the feature flag instance_streaming_audit_events
and when it is enabled it shows the Streams
tab in Instance level Audit events page
Screenshots or screen recordings
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Enable the feature flag
Feature.enable(:instance_streaming_audit_events)
- Navigate to Admin menu and go to Monitoring -> Audit Events
- Ensure that the
Streams
tab is visible. - Note: Clicking on this will cause an error due to backend APIs not setup correctly. This will be solved in subsequent MRs
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #398107 (closed)
Merge request reports
Activity
changed milestone to %16.0
assigned to @nrosandich
added docs-only label
added 1284 commits
-
56602c96...652e185d - 1283 commits from branch
master
- 3499f1fd - Add feature flag and show new tab
-
56602c96...652e185d - 1283 commits from branch
- A deleted user
added backend feature flag labels
1 Warning Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Dzmitry Meshcharakou (
@dmeshcharakou
) (UTC+2)Brian Williams (
@bwill
) (UTC-5)frontend Ross Byrne (
@robyrne
) (UTC+1)Simon Knox (
@psimyn
) (UTC+10)groupcompliance Reviewer review is optional for groupcompliance Jay Montal (
@jmontal
) (UTC-6)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved backend feature flag labels
removed docs-only label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@0c4ddde7
- A deleted user
added backend feature flag labels
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@6930de5a
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 2952f836expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 0 | 23 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 2952f836expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 68 | 0 | 0 | 2 | 68 | ❗ | | Plan | 150 | 0 | 0 | 14 | 150 | ❗ | | Manage | 66 | 0 | 4 | 14 | 70 | ❗ | | Create | 262 | 0 | 44 | 6 | 306 | ❗ | | Release | 12 | 0 | 0 | 2 | 12 | ❗ | | Verify | 106 | 0 | 8 | 0 | 114 | ✅ | | Govern | 92 | 0 | 0 | 14 | 92 | ❗ | | Fulfillment | 4 | 0 | 50 | 0 | 54 | ✅ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Secure | 4 | 0 | 18 | 0 | 22 | ✅ | | Monitor | 16 | 0 | 4 | 0 | 20 | ✅ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 4 | 0 | 0 | 4 | 4 | ❗ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 784 | 0 | 148 | 56 | 932 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Frédéric Caplette
@jmontal Can you please do the initial groupcompliance, backend and frontend review? Not sure if that is allowed
requested review from @jmontal
8 8 #js-audit-log-app{ data: { form_path: admin_audit_logs_path, 9 9 events: @events.to_json, 10 10 is_last_page: @is_last_page.to_json, 11 group_path: 'instance', changed this line in version 3 of the diff
- Resolved by Frédéric Caplette
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ee84beb5
- Resolved by Nate Rosandich
- Resolved by Frédéric Caplette
question (non-blocking): Could we add some coverage for the new tab (just that it shows) in
ee/spec/features/admin/admin_audit_logs_spec.rb
?
mentioned in commit b86b31a2
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@9d9d6037
mentioned in issue #409409 (closed)
@jmontal
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@b24fd5a5
requested review from @f_caplette
- Resolved by Nate Rosandich
removed review request for @f_caplette
removed review request for @tkuah
requested review from @f_caplette
requested review from @tkuah
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@f0e31a87
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ea493a02
removed review request for @tkuah
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@30e043e4
requested review from @jmontal
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@5614ab99
enabled an automatic merge when the pipeline for 5614ab99 succeeds
removed review request for @jmontal
mentioned in commit 7c8abf3a
added 1640 commits
-
746e4aef...a811e8b4 - 1637 commits from branch
master
- 7c8abf3a - Add feature flag and show new tab
- 5d7b26c0 - Move data injection to helper
- 2952f836 - Add spec for audit log data
Toggle commit list-
746e4aef...a811e8b4 - 1637 commits from branch
enabled an automatic merge when the pipeline for 51d0ff9d succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@51d0ff9d
mentioned in commit 1f66473e
mentioned in commit 86c62c1e
added self-managed workflowstaging-canary labels and removed self-managed workflowplanning breakdown labels
added self-managed workflowstaging labels and removed self-managed workflowstaging-canary labels
added self-managed workflowcanary labels and removed self-managed workflowstaging labels
added self-managed workflowproduction labels and removed self-managed workflowcanary labels
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2145 (merged)
mentioned in merge request !121102 (merged)
mentioned in merge request !131851 (merged)