Skip to content

Move common methods in webhook controllers to concern

Anton Smith requested to merge refactor/hooks-controller-shared-functions into master

What does this MR do and why?

Closes #370710 (closed)

Moves the hook_logs functions from various hook controllers into the WebHooks::HookActions concern.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

N/A

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create one of each of the different hook types:
  2. For each hook, test them (this will generate a hook log) https://docs.gitlab.com/ee/user/project/integrations/webhooks.html#test-a-webhook
  3. Edit each hook - if you can view the recent events (hook logs) generated from the test that means everything is working. See https://docs.gitlab.com/ee/user/project/integrations/webhooks.html#troubleshooting for an example on what the recent events (hook logs) look like in the UI.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Anton Smith

Merge request reports