Skip to content

Add as-if-foss to depenendencies for rspec:coverage

Brian Williams requested to merge bwill/make-coverage-depend-on-as-if-foss into master

What does this MR do and why?

Describe in detail what your merge request does and why.

The rspec:undercoverage job is currently flaky when testing FOSS methods. When the same method exists in both FOSS and EE, the EE version of the method is tested with rspec unit pg13 and the FOSS version of the method is tested with rspec unit pg13-as-if-foss. If rspec unit pg13-as-if-foss has not completed by the time rspec:coverage runs, then rspec:undercoverage will fail and report that the FOSS version of the method has no test coverage.

Examples:

  1. https://gitlab.com/gitlab-org/gitlab/-/jobs/4165789053
  2. https://gitlab.com/gitlab-org/gitlab/-/jobs/4186068853

This MR adds as-if-foss specs to the dependencies for rspec:coverage. This ensures that the as-if-foss jobs are finished before the coverage report is generated, which should remove the race condition.

Manual tests:

  1. FOSS pipeline: !118941 (closed)
  2. EE pipeline: !118942 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Brian Williams

Merge request reports