Skip to content

Fix compliance framework creation error on GitLab premium plans

Huzaifa Iftikhar requested to merge 408957_fix_framework_creation_error_for_premium into master

What does this MR do and why?

  1. Fix a bug that prevented users on GitLab Premium plan to create compliance frameworks.
  2. Added RSpecs to assert this condition.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Simulate GitLab SaaS by following the steps in this doc.
  2. Create a group and set the plan as premium from the group admin settings.
  3. Create a new compliance framework in that group (keeping the pipeline configuration path as nil)
  4. Ensure that you are able to create the compliance framework successfully. (On current master this step would result in an error)

Watch this video for reference - https://www.loom.com/share/f221a32e70b04b7791863df08cddefcd

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #408957 (closed)

Edited by Huzaifa Iftikhar

Merge request reports