Fix loading Web IDE Beta outside gitlab_url
What does this MR do and why?
Fix loading Web IDE Beta outside gitlab_url (see originating thread in Web IDE Feedback issue).
- Previously we depended on
gitlab_url
which meant that the Web IDE would only work if the browser accessing the Web IDE visited the same origin/URL ansgitlab_url
. - Now we just depend on the browser's
location.origin
which should make us a bit more flexible
Changelog: fixed
Screenshots or screen recordings
Before | After |
---|---|
... |
How to set up and validate locally
- Make sure the
vscode_web_ide
feature flag is enabled - Visit the Web IDE in the local GDK instance
- In the browser URL, replace the local GDK's configured hostname with something else that still resolves to the GDK instance (for example,
127.0.0.1
orlocalhost
) - Confirm that the Web IDE still loads the file tree
👍
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Michael Kozono