Add support for TOFA AI API
What does this MR do and why?
More context [internal only]: https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/3210#note_1367778377
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @bmarjanovic
- A deleted user
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aakriti Gupta (
@aakriti.gupta
) (UTC+2, same timezone as@bmarjanovic
)Bob Van Landuyt (
@reprazent
) (UTC+2, same timezone as@bmarjanovic
)database Mohamed Hamda (
@mhamda
) (UTC+2, same timezone as@bmarjanovic
)Mayra Cabrera (
@mayra-cabrera
) (UTC-6, 8 hours behind@bmarjanovic
)~"migration" No reviewer available No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- A deleted user
added Data WarehouseImpact Check label
added devopsgovern sectionsec labels
@mksionek
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @acroitor and @georgekoltsov
- Resolved by Adam Hegyi
@acroitor @georgekoltsov ready for you!
added databasereviewed label and removed databasereview pending label
requested review from @ahegyi
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@454f3a21
added Data WarehouseNot Impacted label and removed Data WarehouseImpact Check label
added databaseapproved label and removed databasereviewed label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@b973c74d
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ee0c0ef4
mentioned in issue #408249 (closed)
Allure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 1244e4b5expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Fulfillment | 4 | 0 | 48 | 0 | 52 | ✅ | | Govern | 92 | 0 | 0 | 92 | 92 | ❗ | | Verify | 108 | 0 | 8 | 88 | 116 | ❗ | | Plan | 120 | 0 | 0 | 66 | 120 | ❗ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Create | 292 | 0 | 42 | 50 | 334 | ❗ | | Manage | 64 | 2 | 6 | 16 | 72 | ❌ | | Data Stores | 68 | 0 | 0 | 16 | 68 | ❗ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Monitor | 16 | 0 | 4 | 16 | 20 | ❗ | | Release | 12 | 0 | 0 | 8 | 12 | ❗ | | Analytics | 4 | 0 | 0 | 4 | 4 | ❗ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Secure | 14 | 0 | 10 | 14 | 24 | ❗ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 794 | 2 | 138 | 370 | 934 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
added 122 commits
-
d22b4378...3c29b511 - 121 commits from branch
master
- a89f1c85 - Add support for TOFA AI API
-
d22b4378...3c29b511 - 121 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@2bf8764f
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
enabled an automatic merge when the pipeline for 75d7f5da succeeds
assigned to @jessieay
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@75d7f5da
added pipeline:skip-undercoverage label
enabled an automatic merge when the pipeline for a5e0d4d8 succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@a5e0d4d8
Hello @bmarjanovic
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit a881eb14
changed milestone to %16.0
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2145 (merged)
mentioned in issue bmarjanovic/growth-and-development#1